add all apis to 2020 readme (Azure#14870)

* add all apis to 2020 readme * fix * add 2020 to Go Readme * change error definitions in 2020-02-02 * changes to fix issues * fix more errors * change error response to custom to fix errors * add code property to error * fix error response * change errorResponse name * fix * fix * fix * fix * fix * fix * fix * fix * fixes * fixes * fix * fixes * fix remaining issues in readme.go.md Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
toddm · Jun 30, 2021 · 4483c52 · 4483c52
1 parent 34342af
commit 4483c52
Show file tree

Hide file tree

Showing 7 changed files with 70 additions and 44 deletions.
diff --git a/...ger/Microsoft.Insights/preview/2017-10-01/examples/CurrentPricingPlanCreateAndUpdate.json b/...ger/Microsoft.Insights/preview/2017-10-01/examples/CurrentPricingPlanCreateAndUpdate.json
@@ -7,12 +7,9 @@
     "PricingPlanProperties": {
       "id": "/subscriptions/subid/resourceGroups/my-resource-group/providers/microsoft.insights/components/my-component/pricingPlans/current",
       "name": "current",
-      "type": "microsoft.insights/components/pricingPlans",
       "properties": {
         "planType": "Basic",
         "cap": 500,
-        "maxHistoryCap": 500,
-        "resetHour": 16,
         "warningThreshold": 90,
         "stopSendNotificationWhenHitThreshold": false,
         "stopSendNotificationWhenHitCap": false

diff --git a/...urce-manager/Microsoft.Insights/preview/2017-10-01/examples/CurrentPricingPlanUpdate.json b/...urce-manager/Microsoft.Insights/preview/2017-10-01/examples/CurrentPricingPlanUpdate.json
@@ -7,7 +7,6 @@
     "PricingPlanProperties": {
       "id": "/subscriptions/subid/resourceGroups/my-resource-group/providers/microsoft.insights/components/my-component/pricingPlans/current",
       "name": "current",
-      "type": "microsoft.insights/components/pricingPlans",
       "properties": {
         "planType": "Basic",
         "cap": 500,

diff --git a/...ger/Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json b/...ger/Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json
@@ -59,7 +59,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseLinkedStorage"
             }
           },
           "200": {
@@ -108,7 +108,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseLinkedStorage"
             }
           },
           "200": {
@@ -157,7 +157,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseLinkedStorage"
             }
           },
           "200": {
@@ -197,7 +197,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseLinkedStorage"
             }
           },
           "200": {
@@ -216,17 +216,24 @@
     }
   },
   "definitions": {
-    "ErrorResponse": {
-      "description": "Error response indicates Insights service is not able to process the incoming request. The reason is provided in the error message.",
+    "ErrorResponseLinkedStorage": {
       "type": "object",
       "properties": {
-        "code": {
-          "description": "Error code.",
-          "type": "string"
-        },
-        "message": {
-          "description": "Error message indicating why the operation failed.",
-          "type": "string"
+        "error": {
+          "description": "Error response indicates Insights service is not able to process the incoming request. The reason is provided in the error message.",
+          "type": "object",
+          "properties": {
+            "code": {
+              "readOnly": true,
+              "description": "Error code.",
+              "type": "string"
+            },
+            "message": {
+              "readOnly": true,
+              "description": "Error message indicating why the operation failed.",
+              "type": "string"
+            }
+          }
         }
       }
     },

diff --git a/...nsights/resource-manager/Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json b/...nsights/resource-manager/Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json
@@ -93,7 +93,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../2020-03-01-preview/componentLinkedStorageAccounts_API.json#/definitions/ErrorResponse"
+              "$ref": "../2020-03-01-preview/componentLinkedStorageAccounts_API.json#/definitions/ErrorResponseLinkedStorage"
             }
           },
           "200": {

diff --git a/...icationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json b/...icationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json
@@ -56,7 +56,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseComponents"
             }
           }
         },
@@ -95,7 +95,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseComponents"
             }
           }
         },
@@ -137,7 +137,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseComponents"
             }
           }
         },
@@ -174,7 +174,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseComponents"
             }
           }
         },
@@ -220,7 +220,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseComponents"
             }
           }
         },
@@ -269,7 +269,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseComponents"
             }
           }
         },
@@ -311,7 +311,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseComponents"
             }
           }
         },
@@ -353,7 +353,7 @@
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
-              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
+              "$ref": "#/definitions/ErrorResponseComponents"
             }
           }
         },
@@ -366,6 +366,27 @@
     }
   },
   "definitions": {
+    "ErrorResponseComponents": {
+      "type": "object",
+      "properties": {
+        "error": {
+          "description": "Error response indicates Insights service is not able to process the incoming request. The reason is provided in the error message.",
+          "type": "object",
+          "properties": {
+            "code": {
+              "readOnly": true,
+              "description": "Error code.",
+              "type": "string"
+            },
+            "message": {
+              "readOnly": true,
+              "description": "Error message indicating why the operation failed.",
+              "type": "string"
+            }
+          }
+        }
+      }
+    },
     "ComponentsResource": {
       "properties": {
         "id": {

diff --git a/specification/applicationinsights/resource-manager/readme.go.md b/specification/applicationinsights/resource-manager/readme.go.md
@@ -14,6 +14,7 @@ go:
 ``` yaml $(go) && $(multiapi)
 batch:
   - tag: package-2015-05
+  - tag: package-2020-02-02
 ```
 
 ### Tag: package-2015-05 and go
@@ -25,24 +26,11 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s
 output-folder: $(go-sdk-folder)/services/appinsights/mgmt/2015-05-01/$(namespace)
 ```
 
-### Tag: schema-2015-05-preview
+### Tag: package-2020-02-02 and go
 
-These settings apply only when `--tag=schema-2015-05-01` is specified on the
-command line.
-
-This section contains the input swagger files that are used when generating
-resource manager schemas for version 2015-05-01. Note that many of our
-pre-existing APIs are note currently compatible with ARM schemas, upon any
-updates applied to our services we will bring them up to compliance.
-
-``` yaml $(tag) == 'schema-2015-05-01'
-input-file:
- - ./Microsoft.Insights/stable/2015-05-01/aiOperations_API.json
- - ./Microsoft.Insights/stable/2015-05-01/components_API.json
- - ./Microsoft.Insights/stable/2015-05-01/webTests_API.json
- - ./Microsoft.Insights/stable/2015-05-01/workbooks_API.json
- - ./Microsoft.Insights/stable/2015-05-01/myworkbooks_API.json
+These settings apply only when `--tag=package-2020-02-02 --go` is specified on he command line.
+Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.
 
-override-info:
-  title: ApplicationInsightsManagementClient
+``` yaml $(tag) == 'package-2020-02-02' && $(go)
+output-folder: $(go-sdk-folder)/services/preview/appinsights/mgmt/2020-02-02-preview/$(namespace)
 ```
diff --git a/specification/applicationinsights/resource-manager/readme.md b/specification/applicationinsights/resource-manager/readme.md
@@ -360,7 +360,21 @@ These settings apply only when `--tag=package-2020-02-02` is specified on the co
 
 ``` yaml $(tag) == 'package-2020-02-02'
 input-file:
+- Microsoft.Insights/stable/2015-05-01/aiOperations_API.json
+- Microsoft.Insights/stable/2015-05-01/componentAnnotations_API.json
+- Microsoft.Insights/stable/2015-05-01/componentApiKeys_API.json
+- Microsoft.Insights/stable/2015-05-01/componentContinuousExport_API.json
+- Microsoft.Insights/stable/2015-05-01/componentFeaturesAndPricing_API.json
+- Microsoft.Insights/stable/2015-05-01/componentProactiveDetection_API.json
+- Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json
+- Microsoft.Insights/stable/2015-05-01/favorites_API.json
+- Microsoft.Insights/stable/2015-05-01/webTestLocations_API.json
+- Microsoft.Insights/stable/2015-05-01/webTests_API.json
+- Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json
+- Microsoft.Insights/stable/2015-05-01/workbooks_API.json
+- Microsoft.Insights/stable/2015-05-01/myworkbooks_API.json
 - Microsoft.Insights/stable/2020-02-02/components_API.json
+- Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json
 ```
 
 ### Tag: package-2019-10-17-preview