Skip to content

feat: display buildings' internal resource buffer during dev #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fehnomenal
Copy link
Collaborator

I found it quite interesting to observe the buffers filling up.
Sadly, the block is not removed in the build but at least it is not displayed.

Copy link

vercel bot commented Nov 11, 2024

@fehnomenal is attempting to deploy a commit to the toddeTV private projects team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Upgrade to pro and add @fehnomenal as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here to upgrade and add @fehnomenal as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the toddeTV private projects team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zlig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 6:13pm

Copy link
Owner

@toddeTV toddeTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea for debugging - increasing numbers always have a certain appeal 😉

However, let's not use the additional package esm-env. Instead, simply place this in the debug section at the bottom left of the menu. This way, it will always be part of the debugging tools, which can later be shown or hidden through a global mechanism based on a GET URL key, cookies, or similar.

@fehnomenal
Copy link
Collaborator Author

Changed, please have another look.

@toddeTV
Copy link
Owner

toddeTV commented Jan 22, 2025

It would be better to make this part of the debug block in the lower left sidebar.

I'm unsure, though, whether it might be better represented with a progress bar. Also, what happens if the numbers get very large? We don't have a solution for that in the game yet (will we eventually switch to suffixes like K for thousand, M for million, etc.?).

So, I'd suggest putting this on hold for now and focusing our resources on more important tasks. We can revisit this later.

@toddeTV toddeTV removed their request for review January 22, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants