Dynamic App Loader Helper #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
suggested changes
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
examples/tests/app_loader/main.c
Outdated
| uint32_t app_size = 0; // variable to store app size | ||
|
|
||
| // Tock Application Binary to be flashed. | ||
| const uint8_t app_binary[] = {0x2, 0x0, 0x34, 0x0, 0x0, 0x8, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0xD7, 0x75, 0x50, 0x6E, |
There was a problem hiding this comment.
This application can build for any architecture. How does this data then work?
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
examples/tests/app_loader/main.c
Outdated
| } | ||
|
|
||
| for (uint32_t offset = 0; offset < write_count; offset++) { | ||
| memcpy(write_buffer, &app_binary[FLASH_BUFFER_SIZE * offset], FLASH_BUFFER_SIZE); // copy binary to write buffer |
There was a problem hiding this comment.
What if app_binary isn't a multiple of FLASH_BUFFER_SIZE?
alistair23
reviewed
Apr 2, 2024
alistair23
reviewed
Apr 2, 2024
ppannuto
added
the
blocked-on-kernel
viswajith-g
force-pushed
the
app_loader
branch
from
60c2770 to
42b0c51
Compare
this app sends the tab file of an app that needs to be flashed to the capsule. once the app binary is written to flash, the userland app requests kernel to load the app.
… in internal/binaries.c. cleaned up and formatted removed old code removed userspace code from a previous implementation that was giving rise to confusion. added comments to app_loader.h added binaries headers and updated code added binaries in external files to make the app file more readable. Added a new subscribe and callback to support the async setup update readme
added tock-dpl-hello and tock-welcomes-dpl. The first app is a simple c_hello analog that prints a message and terminates on boot. The second app is a helper app that installs tock-dpl-hello on the board during runtime. These apps were made to test the dynamic process loading using hw-ci.
viswajith-g
force-pushed
the
app_loader
branch
from
42b0c51 to
f653234
Compare
|
Can you rebase this on master and
|
…hon tool to tests.
I believe the repo was already rebased on master last time i pushed it.
Done. I also renamed the functions to start with libtock_ to keep in line with the other the new libtock format.
Done |
bradjc
reviewed
Feb 13, 2025
| @@ -0,0 +1,1304 @@ | |||
| #include <examples/tests/app_loader/button-press-loading/app_binaries.h> | |||
There was a problem hiding this comment.
Suggested change
| #include <examples/tests/app_loader/button-press-loading/app_binaries.h> | |
| #include "app_binaries.h" |
There was a problem hiding this comment.
Move these to libtock/kernel
Comment on lines
2
to
7
| // #include "libtock/tock.h" | ||
|
|
||
| // bool libtock_app_loader_exists(void) { | ||
| // syscall_return_t res = command(DRIVER_NUM_APP_LOADER, 0, 0, 0); | ||
| // return tock_command_return_novalue_to_returncode(res); | ||
| // } |
There was a problem hiding this comment.
Suggested change
| // #include "libtock/tock.h" | |
| // bool libtock_app_loader_exists(void) { | |
| // syscall_return_t res = command(DRIVER_NUM_APP_LOADER, 0, 0, 0); | |
| // return tock_command_return_novalue_to_returncode(res); | |
| // } |
lvgl/lvgl
Outdated
There was a problem hiding this comment.
i did not touch this though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the helper app to validate the kernel's dynamic process loading functionality (tock/tock#3941). The helper app triggers the dynamic process loading with a button press.
This application is located in
/examples/tests/app_loaderand was tested on the nRF52840DK. A previous version of the dynamic process loader was tested with the same application on an Imix board as well.