refactor!!: make scope traversal significantly faster#7196
Merged
Conversation
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 9416 total, 8409 passed (pass rate: 89.3%), sqlglot version: sqlglot:toby/scope: 9416 total, 8419 passed (pass rate: 89.4%), sqlglot version: Transitions: |
geooo109
approved these changes
Mar 4, 2026
mypyc has an issue with the nested generators, so inlining a DFS search gives signifcant gains ┌──────────────────────────────────────┬─────────────────┬─────────────────┐ │ Version │ median │ best │ ├──────────────────────────────────────┼─────────────────┼─────────────────┤ │ Unrolled walk_in_scope │ 1.381ms (1.84x) │ 1.376ms (1.65x) │ ├──────────────────────────────────────┼─────────────────┼─────────────────┤ │ expression.walk() delegation (tuple) │ 2.333ms (1.09x) │ 1.847ms (1.23x) │ ├──────────────────────────────────────┼─────────────────┼─────────────────┤ │ Baseline (8db0323) │ 2.550ms │ 2.271ms │ └──────────────────────────────────────┴─────────────────┴─────────────────┘
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypyc has an issue with the nested generators, so inlining a DFS search gives signifcant gains
┌──────────────────────────────────────┬─────────────────┬─────────────────┐
│ Version │ median │ best │
├──────────────────────────────────────┼─────────────────┼─────────────────┤
│ Unrolled walk_in_scope │ 1.381ms (1.84x) │ 1.376ms (1.65x) │
├──────────────────────────────────────┼─────────────────┼─────────────────┤
│ expression.walk() delegation (tuple) │ 2.333ms (1.09x) │ 1.847ms (1.23x) │
├──────────────────────────────────────┼─────────────────┼─────────────────┤
│ Baseline (8db0323) │ 2.550ms │ 2.271ms │
└──────────────────────────────────────┴─────────────────┴─────────────────┘