Feat(snowflake): improve transpilation of queries with UNNEST sources #5408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transpiling BigQuery queries to Snowflake is not always correct today. One example is:
The transpiler's output is not valid Snowflake, because the identifier
xreferenced in the projection list does not exist. Instead, only the identifiers mentioned in the table alias are visible, and accessingxrequires extracting it fromvalue.To address this issue, I implemented a rule that conditionally qualifies
UNNESTsources and the columns they produce, if we can statically determine them.After this rule is applied, a followup rule, already in effect today, takes care of converting the qualified columns into the proper bracket expressions used to extract values out of
VARIANTobjects, which leads to a correct transpilation.