Skip to content

Conversation

@georgesittas
Copy link
Collaborator

Fixes #5132

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Parsing Benchmark

Benchmark bench_parse_pr bench_parse_main
parse_sqlglot_tpch 5.64 ms 5.58 ms: 1.01x faster
parse_sqlglot_short 349 us 347 us: 1.01x faster
parse_sqlglotrs_tpch 4.11 ms 4.05 ms: 1.01x faster
Geometric mean (ref) 1.00x faster

Benchmark hidden because not significant (5): parse_sqlglot_long, parse_sqlglot_crazy, parse_sqlglotrs_short, parse_sqlglotrs_long, parse_sqlglotrs_crazy


Optimization Benchmark

Benchmark bench_optimize_pr bench_optimize_main
optimize_tpch 740 ms 747 ms: 1.01x slower
optimize_condition_100 89.8 ms 91.0 ms: 1.01x slower
optimize_condition_1000 2.85 sec 2.89 sec: 1.01x slower
Geometric mean (ref) 1.01x slower

Benchmark hidden because not significant (1): optimize_condition_10

@georgesittas georgesittas merged commit 1a35365 into main Jun 2, 2025
7 checks passed
@georgesittas georgesittas deleted the jo/avoid_generating_nested_comments branch June 2, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested comments can transpile to invalid sql

3 participants