Skip to content

Conversation

@benfdking
Copy link
Collaborator

@benfdking benfdking commented May 29, 2025

Fixes #5134

Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a question from me, LGTM otherwise.

@github-actions
Copy link
Contributor

Benchmark for cc8b9d8

Click to view benchmark
Test Base PR %
long 209.0±10.54µs 210.7±2.76µs +0.81%

@georgesittas georgesittas merged commit 3935a3c into main May 29, 2025
7 checks passed
@georgesittas georgesittas deleted the update_py03 branch May 29, 2025 11:06
georgesittas pushed a commit that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please update sqlglotrs to use modern PyO3

3 participants