Skip to content

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Apr 9, 2025

Fixes #4956

@VaggelisD
Copy link
Collaborator

Hey @mscolnick, thank you for the PR!

Could we please fix the CI/CD? For quicker iterations you can run make style & make unit locally before pushing.

Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I'll take this to the finish line.

@georgesittas georgesittas merged commit 7fce610 into tobymao:main Apr 9, 2025
0 of 6 checks passed
georgesittas added a commit that referenced this pull request Apr 9, 2025
* fix: support SHOW (ALL) TABLES for duckdb

* Fix styling

* Fix set difference

* Fix styling

* Preserve ALL prefix

* Fix test

* Fix formatting

---------

Co-authored-by: Jo <46752250+georgesittas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHOW ALL TABLES parsing in duckdb
3 participants