fix(tsql): support default values on definitons and the OUTPUT/OUT/READ_ONLY syntax #4704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geooo109
requested review from
VaggelisD and
georgesittas
and removed request for
georgesittas
VaggelisD
reviewed
Feb 5, 2025
Collaborator
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
Looks good, left a couple comments 👍
geooo109
force-pushed
the
geooo109/tsql_support_init_and_output
branch
from
1a611be to
ff27776
Compare
VaggelisD
reviewed
Feb 5, 2025
georgesittas
approved these changes
Feb 5, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Minor comment, LGTM otherwise.
CrispinStichartFNSB
added a commit
to CrispinStichartFNSB/sqlglot
that referenced
this pull request
Jul 15, 2025
In PR tobymao#4704, support for OUT, OUTPUT, and READ_ONLY parameter modifiers. However, READ_ONLY is not correct -- it should be READONLY. See the documentation for procedures as functions: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-procedure-transact-sql?view=sql-server-ver16#readonly https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql?view=sql-server-ver17#readonly
georgesittas
pushed a commit
that referenced
this pull request
Jul 15, 2025
In PR #4704, support for OUT, OUTPUT, and READ_ONLY parameter modifiers. However, READ_ONLY is not correct -- it should be READONLY. See the documentation for procedures as functions: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-procedure-transact-sql?view=sql-server-ver16#readonly https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql?view=sql-server-ver17#readonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support:
CREATE PROCEDURE test(@input INT = 1,DECLARE @var AS INTEGER = 1)OUTPUT/OUT/READONLYkeywords, which primarily serve to return scalar values or enforce immutability (e.g.CREATE PROCEDURE test(@out_var INT OUTPUT))DOCS
T-SQL Stored Procedures Paramaters