Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tsql): support PRIMARY KEY constraint with DESC, ASC #4610 #4618

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(tsql): support PRIMARY KEY constraint with DESC, ASC #4610 #4618

merged 1 commit into from
Jan 15, 2025
+8 −1

Conversation

geooo109
Copy link
Collaborator

@geooo109 geooo109 commented Jan 15, 2025 •
edited
Loading

Fixes #4610

This PR adds support for using DESC or ASC in the PRIMARY KEY constraint definition.

Example:
CREATE TABLE db.t1 (a INTEGER, b VARCHAR(50), CONSTRAINT c PRIMARY KEY (a DESC))

DOCS
T-SQL Constraints

@georgesittas georgesittas merged commit 14474ee into main Jan 15, 2025
7 checks passed
@georgesittas georgesittas deleted the geooo109/tsql_primary_key_constraint branch January 15, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

@VaggelisD VaggelisD VaggelisD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSQL: PRIMARY KEY constraint fails to parse if sort option is given
3 participants
@geooo109 @VaggelisD @georgesittas