Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify to insert SslEnforcer before the Cookies middleware in Rails #90

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Specify to insert SslEnforcer before the Cookies middleware in Rails #90

merged 1 commit into from
Oct 19, 2016

Conversation

DimaSamodurov
Copy link
Contributor

If you simply use Rack::SslEnforcer in Rails, it is placed to the end of the middleware chain.
Then in case of ssl_request? cookies are not yet committed to the headers keeping flag_cookies_as_secure! ineffective.

@DimaSamodurov DimaSamodurov changed the title Specify to insert SslEnforcer before the Cookies middleware Specify to insert SslEnforcer before the Cookies middleware in Rails Sep 19, 2016
@tobmatth tobmatth merged commit 414880d into tobmatth:master Oct 19, 2016
@tobmatth
Copy link
Owner

Thank you, merged.

@toncid toncid mentioned this pull request Jan 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimaSamodurov @tobmatth