[ios] added depthbuffer to gles for exciting things later on

tobithiel · Jul 16, 2011 · c9ca971 · c9ca971
1 parent 5070607
commit c9ca971
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 5 deletions.
diff --git a/xbmc/osx/atv2/XBMCEAGLView.h b/xbmc/osx/atv2/XBMCEAGLView.h
@@ -34,7 +34,7 @@
   GLint framebufferWidth;
   GLint framebufferHeight;
   // The OpenGL ES names for the framebuffer and renderbuffer used to render to this view.
-  GLuint defaultFramebuffer, colorRenderbuffer;
+  GLuint defaultFramebuffer, colorRenderbuffer, depthRenderbuffer;
 	// the shader program object
 	GLuint program;
 	//

diff --git a/xbmc/osx/atv2/XBMCEAGLView.mm b/xbmc/osx/atv2/XBMCEAGLView.mm
@@ -146,9 +146,13 @@ - (void)createFramebuffer
     [context renderbufferStorage:GL_RENDERBUFFER fromDrawable:(CAEAGLLayer *)self.layer];
     glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_WIDTH, &framebufferWidth);
     glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_HEIGHT, &framebufferHeight);
-
     glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, colorRenderbuffer);
-
+
+    glGenRenderbuffers(1, &depthRenderbuffer);
+    glBindRenderbuffer(GL_RENDERBUFFER, depthRenderbuffer);
+    glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT16, framebufferWidth, framebufferHeight);
+    glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, depthRenderbuffer);
+
     if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE)
       NSLog(@"Failed to make complete framebuffer object %x", glCheckFramebufferStatus(GL_FRAMEBUFFER));
   }
@@ -172,6 +176,12 @@ - (void) deleteFramebuffer
       glDeleteRenderbuffers(1, &colorRenderbuffer);
       colorRenderbuffer = 0;
     }
+
+    if (depthRenderbuffer)
+    {
+      glDeleteRenderbuffers(1, &depthRenderbuffer);
+      depthRenderbuffer = 0;
+    }
   }
 }
 //--------------------------------------------------------------

diff --git a/xbmc/osx/ios/XBMCEAGLView.h b/xbmc/osx/ios/XBMCEAGLView.h
@@ -34,7 +34,7 @@
   GLint framebufferWidth;
   GLint framebufferHeight;
   // The OpenGL ES names for the framebuffer and renderbuffer used to render to this view.
-  GLuint defaultFramebuffer, colorRenderbuffer;
+  GLuint defaultFramebuffer, colorRenderbuffer, depthRenderbuffer;
 	// the shader program object
 	GLuint program;
 	//

diff --git a/xbmc/osx/ios/XBMCEAGLView.mm b/xbmc/osx/ios/XBMCEAGLView.mm
@@ -151,8 +151,12 @@ - (void)createFramebuffer
     [context renderbufferStorage:GL_RENDERBUFFER fromDrawable:(CAEAGLLayer *)self.layer];
     glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_WIDTH, &framebufferWidth);
     glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_HEIGHT, &framebufferHeight);
-
     glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, colorRenderbuffer);
+
+    glGenRenderbuffers(1, &depthRenderbuffer);
+    glBindRenderbuffer(GL_RENDERBUFFER, depthRenderbuffer);
+    glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT16, framebufferWidth, framebufferHeight);
+    glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, depthRenderbuffer);
 
     if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE)
       NSLog(@"Failed to make complete framebuffer object %x", glCheckFramebufferStatus(GL_FRAMEBUFFER));
@@ -177,6 +181,12 @@ - (void) deleteFramebuffer
       glDeleteRenderbuffers(1, &colorRenderbuffer);
       colorRenderbuffer = 0;
     }
+
+    if (depthRenderbuffer)
+    {
+      glDeleteRenderbuffers(1, &depthRenderbuffer);
+      depthRenderbuffer = 0;
+    }
   }
 }
 //--------------------------------------------------------------