-
Notifications
You must be signed in to change notification settings - Fork 0
Remove GAP_ROOT_PATHS handling in src/sage #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: tobiasdiez <5037600+tobiasdiez@users.noreply.github.com>
|
@orlitzky |
|
Not losing my job to AI today. The point of the direct-file-access timestamp is to be fast, but I think |
|
So if I understand you correctly, your proposal would be to keep (This PR was triggered by sagemath#40327 (comment) where you suggested that one might be able to completely remove this variable). |
|
First, we can stop passing the Right now we are using the complicated to get But if you don't pass
This becomes relevant because, in the workspace code, we are only using two of those:
In So I think we have three options after removing
Option 3 is probably the fastest, but using pkg-config is also very fast, and has the benefit of eliminating the variable entirely. |
This PR removes the circular and redundant
GAP_ROOT_PATHShandling from the Sage codebase.Problem
The current implementation has a circular dependency:
GAP_ROOT_PATHSconfig variable-lflagThis is unnecessary because GAP already knows its own root paths and doesn't need to be told them explicitly.
Changes
Build Configuration
GAP_ROOT_PATHSvariable definitionRuntime Configuration
GAP_ROOT_PATHSvariable and its default valueGAP Interfaces
-l "{GAP_ROOT_PATHS}"flag when starting GAP. GAP now uses its built-in default root paths.-lflag from libgap initialization. Adjusted argv indices accordingly.Workspace Management
Benefits
Testing
All modified Python files pass syntax validation. The changes maintain backward compatibility - GAP will use its default root paths, which are the same paths we were previously passing to it.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.