Fix fish shell variable scope in init command #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a fish shell variable scope bug where the
cdcommand was not being executed after selecting a directory.Problem
In fish shell, variables declared with
set -linsideswitchcase blocks are scoped to that block only. This caused thecmdvariable to be undefined outside the switch statement, resulting in the cd command not being executed.Solution
cmdvariable before the switch statement withset -l cmd ""set(without-l) inside case blocks to update the outer scope variableTesting
All existing tests pass after this fix (22 tests, 68 assertions).