Delete private key #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix key_present when using key_id
update documentation
Modified the invocation of the delete command to --delete-secret-and-public-keys. Modified the _get_key_from_file code to return the key fingerprint rather than the ID and to use machine readable output from the gpg command. Also added a --batch to the import as I was experiencing some hanging while importing from a key file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to enable the user to delete private keys. Primarily this required a change to the invocation of the delete command but also required a change to the _get_key_from_file to return the key fingerprint rather than the key ID. This has an added advantage that the parsing in _get_key_from_file now uses machine readable output from the gpg command so should be more consistent across versions.