Fix Server.attached_sessions return type #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Server.attached_sessions was documented to return a tmux session object or None but was returning a list of session dicts or None. |
|
It's not clear to me what the right fix is (the note in the docs makes it sound like maybe the list will only every be length 1?) but was going to raise an issue and thought I'd take a whack at it instead. |
|
@thomasballinger Greetings! Nice, I'm taking a look! Can you rebase this so the tests run? I want to be sure it doesn't cause any regressions on older tmux versions. |
|
I made a change at 150fd9c to fix travis tests. |
thomasballinger
force-pushed
the
fix-attached-sessions
branch
from
26c2c61 to
75d5d6b
Compare
tony
added a commit
that referenced
this pull request
Jul 3, 2015
Fix Server.attached_sessions return type
|
Nice @thomasballinger, you're becoming the tmuxp master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.