Fix unwanted changes to other keybindings

[oblitum]

This is a tmux-open keybinding just after (re)loading tmux.conf:

> tmux list-keys

bind-key  -T copy-mode-vi o  send-keys -X copy-pipe-and-cancel "xargs -I {} tmux run-shell -b 'cd #{pane_current_path}; xdg-open \"{}\" > /dev/null'"

Then you execute prefix<c-u> once, it will work, but checking tmux list-keys again, the tmux-open keybinding has changed:

> tmux list-keys

bind-key  -T copy-mode-vi o  send-keys -X copy-pipe-and-cancel "xargs -I {} tmux run-shell -b 'cd #{pane_current_path}; xdg-open {} > /dev/null'"

xdg-open \"{}\" got replaced by xdg-open {} , and tmux-open won't work for URLs containing & and other special chars anymore until reload. There may be a vulnerability here too (because of &some_bad_command).

Migrated from: tmux-plugins/tmux-open#37.

[oblitum]

I think it's due to #119. I think it's possibly not saving/restoring keybinding correctly, like not escaping it properly.

[oblitum]

#121 and #122 are also related.

[oblitum]

@bruno- I've converted the issue into a pull.

[bruno-]

Thanks!

[oblitum]

@bruno- this won't fix it all for tmux-open though.. In the binding

bind-key  -T copy-mode-vi o  send-keys -X copy-pipe-and-cancel "xargs -I {} tmux run-shell -b 'cd #{pane_current_path}; xdg-open \"{}\" > /dev/null'"

The xdg-open \"{}\" part will not honor URLs containing quotes, which is pretty common, for example: https://duckduckgo.com/?q="double+quotes". It will strip them and turn it into https://duckduckgo.com/?q=double+quotes.

• tmux-copycat will not select it correctly too, just up to the first double quote: https://duckduckgo.com/?q=.
• tmux-yank has presented no issues on that.