Bug fixes #28
Merged
Bug fixes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Farwell <josh.farwell@gmail.com>
This was hard-coded, which is a lot better than an injection site, but I want my zip code to show up :) I'm using sqlalchemy.sql.text() to give us parameterized and type-validated input even though we're not using a model here. Returning None for invalid data bubbles up to a 400 error which seems appropriate to me. Signed-off-by: Josh Farwell <josh.farwell@gmail.com>
tmthyjames
reviewed
Apr 14, 2018
| where ST_Contains(geom.geom, ST_MakePoint({lng}, {lat})) | ||
| """.format(lng=-86.725573627, lat=36.227447713)).first() | ||
| where ST_Contains(geom.geom, ST_MakePoint(:lng, :lat)) | ||
| """).bindparams( |
There was a problem hiding this comment.
@sparklespdx, I never knew about this bindparams method! Very cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treatment.timestamp needed a BigInt, updated the model.
Took a crack at un-hardcoding treatment location and making a validated zipcode lookup statement. This returns 400s for not-float latitude or longitude data.
http://docs.sqlalchemy.org/en/latest/core/sqlelement.html#sqlalchemy.sql.expression.TextClause.bindparams