Fixed behavior of doSelect on EINTR #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request on the upstream repo fixes the same issue in a different way: brian-armstrong#16 //Edit: I should have done some basic research: https://golang.org/doc/go1.14#runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this library for quite some time now and recently after upgrading all of my projects to go 1.14 I noticed that its gpio watcher would panic from time to time in
fdSelectin watcher.go line 122.After some investigation I found that the
syscall.SelectindoSelectterminates withEINTR.I have no clue as to why that did not happen before, but possibly the upgrade to go 1.14 or other changes in my environment associated with it caused it.
Anyway, if I remember correctly it should be safe to retry a select after it terminated with
EINTR,so I modified
doSelectaccordingly.