This repository was archived by the owner on Dec 24, 2023. It is now read-only.
Client: Fix VGUI2 chat coloring #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I did: - Substract one to the count in `last_range_idx = m_textRanges.Count()` to avoid going out of bounds from the array. - Put `last_range_idx = m_textRanges.Count() - 1` down of `m_textRanges.AddToTail(range)`, so it can get the right count. - Fixed the start position of the name in `if (*buf2 == 2 && pos == 0)`. - Removed position decreasing for name start in the case when colors are detected. It was messing with the real position.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
last_range_idx = m_textRanges.Count()to avoid going out of bounds from the array.last_range_idx = m_textRanges.Count() - 1down ofm_textRanges.AddToTail(range), so it can get the right count.if (*buf2 == 2 && pos == 0).It requires more testing, but for now it works fine.