Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Facebook Share button #73

Merged
merged 1 commit into from
Feb 18, 2014
Merged

Added support for Facebook Share button #73

merged 1 commit into from
Feb 18, 2014

Conversation

rhodimus
Copy link
Contributor

Added support for Facebook Share button (https://developers.facebook.com/docs/plugins/share-button/).

Requires use of class "facebook-share" and additional data attribute of "data-type" for button type (data attribute difference is Facebook's doing not mine...)

@adasite
Copy link

adasite commented Feb 16, 2014

Can someone write the facebook share button markup for socialite.js? The code below does not work properly:

<a href="http://www.facebook.com/sharer.php?u=url&=post_title" class="socialite facebook-share" data-href="url" data-send="true" data-layout="box_count" data-type="button_count" data-width="60" data-show-faces="false" rel="external nofollow"><span class="hidden">Share on Facebook</span></a>

@rhodimus
Copy link
Contributor Author

Your code works for me: http://jsfiddle.net/AhpFU/

Are you using my fork of Socialite? At least until it gets merged.

@adasite
Copy link

adasite commented Feb 16, 2014

Sorry, it's my fault, I directly used the code you provided via jsfiddle and Facebook Share button appeared now. However I'm not sure that it works as it's expected. All buttons appear directly, no mouse hover or scroll needed. Sorry for my terrible English sir, I think I'm missing something :) Here is a sample page: http://www.fragmansal.com/374/karadayi-59-bolum-fragmani.html

@hgani
Copy link

hgani commented Feb 18, 2014

@rhodimus May I know what is the URL of your fork?

Thanks

@rhodimus
Copy link
Contributor Author

Its here: https://github.com/rhodimus/Socialite/ and the exact changes are linked above in this thread.

@adasite - that all looks ok to me, are you trying to add a mouse hover/scroll?

@aleemb
Copy link

aleemb commented Feb 18, 2014

+1 would be good to see this merged

@adasite
Copy link

adasite commented Feb 18, 2014

rhodimus, I just want to be sure that social buttons load asynchronously. Your fork probably do this. This discussion is my fault as I thought your fork is already merged, sorry.

tmort pushed a commit that referenced this pull request Feb 18, 2014
Added support for Facebook Share button
@tmort tmort merged commit 41187d9 into tmort:master Feb 18, 2014
@tmort
Copy link
Owner

tmort commented Feb 18, 2014

rhodimus, Appreciate you contribution. Seeing this thread light up made me immediately pull it into socialite. Hope this helps everyone when checking out the source!

@cubicova17
Copy link

@tmort it would be also nice to update a paragraph describing his change on http://socialitejs.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants