-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Facebook Share button #73
Conversation
Added support for Facebook Share button (https://developers.facebook.com/docs/plugins/share-button/)
Can someone write the facebook share button markup for socialite.js? The code below does not work properly:
|
Your code works for me: http://jsfiddle.net/AhpFU/ Are you using my fork of Socialite? At least until it gets merged. |
Sorry, it's my fault, I directly used the code you provided via jsfiddle and Facebook Share button appeared now. However I'm not sure that it works as it's expected. All buttons appear directly, no mouse hover or scroll needed. Sorry for my terrible English sir, I think I'm missing something :) Here is a sample page: http://www.fragmansal.com/374/karadayi-59-bolum-fragmani.html |
@rhodimus May I know what is the URL of your fork? Thanks |
Its here: https://github.com/rhodimus/Socialite/ and the exact changes are linked above in this thread. @adasite - that all looks ok to me, are you trying to add a mouse hover/scroll? |
+1 would be good to see this merged |
rhodimus, I just want to be sure that social buttons load asynchronously. Your fork probably do this. This discussion is my fault as I thought your fork is already merged, sorry. |
Added support for Facebook Share button
rhodimus, Appreciate you contribution. Seeing this thread light up made me immediately pull it into socialite. Hope this helps everyone when checking out the source! |
@tmort it would be also nice to update a paragraph describing his change on http://socialitejs.com/ |
Added support for Facebook Share button (https://developers.facebook.com/docs/plugins/share-button/).
Requires use of class "facebook-share" and additional data attribute of "data-type" for button type (data attribute difference is Facebook's doing not mine...)