Skip to content

[WIP] Refactor object_position_server to use FastAPI for its API server #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Refactor object_position_server to use FastAPI for its API server #98

wants to merge 1 commit into from

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Aug 4, 2025 •
edited
Loading

Refactoring object_position_server from Flask to FastAPI

Analysis Complete

  • Explore repository structure and current implementation
  • Understand current Flask-based API with 2 endpoints: /catalog and /position
  • Review current deployment using waitress-serve on port 8876
  • Examine Docker setup and dependencies

Plan for FastAPI Migration

  • Create new FastAPI main.py with equivalent endpoints
  • Convert Flask request parsing to FastAPI query parameters
  • Update error handling to use FastAPI HTTPException
  • Replace waitress with uvicorn in Dockerfile
  • Update docker-compose.yml for FastAPI deployment
  • Test API functionality and OpenAPI docs
  • Update documentation and comments

Current endpoints to migrate:

  • GET /catalog - Object positions in local horizontal coordinates
  • GET /position - SV positions in ECEF coordinates

Key changes needed:

  • Flask app → FastAPI app
  • Flask decorators → FastAPI decorators (@app.get)
  • request.args → FastAPI Query parameters
  • waitress-serve → uvicorn main:app
  • Automatic OpenAPI docs at /docs

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@tmolteno tmolteno marked this pull request as ready for review August 4, 2025 23:34
@Copilot Copilot AI requested a review from tmolteno August 5, 2025 00:31
Copilot stopped work on behalf of tmolteno due to an error August 5, 2025 00:31
Copilot had to stop work due to a timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmolteno tmolteno Awaiting requested review from tmolteno

Assignees

@tmolteno tmolteno

Copilot code review Copilot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Copilot @tmolteno