Fix marshal load error when marshal data includes "\n"#128
Merged
koic merged 1 commit intotmm1:masterfrom Jun 26, 2023
arika:fix-marshal-load-error
Merged
Fix marshal load error when marshal data includes "\n"#128koic merged 1 commit intotmm1:masterfrom arika:fix-marshal-load-error
koic merged 1 commit intotmm1:masterfrom
arika:fix-marshal-load-error
Conversation
Collaborator
|
Can you add the repro test below and squash the commits together afterwards? % git diff .
diff --git a/test/examples/example_testunit.rb b/test/examples/example_testunit.rb
index bf963f7..c16fb07 100644
--- a/test/examples/example_testunit.rb
+++ b/test/examples/example_testunit.rb
@@ -8,6 +8,12 @@ class TestUnitEqual < Test::Unit::TestCase
end
end
+class Short < Test::Unit::TestCase
+ def test_work_with_short_class_name
+ assert true
+ end
+end
+
30.times do |i|
Object.const_set("TestUnitSleep#{i}", Class.new(Test::Unit::TestCase) do
define_method(:test_sleep) doFor reference, the test below can be run: TEST_QUEUE_WORKERS=2 TEST_QUEUE_VERBOSE=1 BUNDLE_GEMFILE=gemfiles/testunit.gemfile bundle install && vendor/bats/bin/bats test/testunit.bats |
Contributor
Author
|
@koic Thank you for your review. |
Collaborator
|
Great! Thanks! |
Collaborator
|
FYI, test-queue 0.10.0 has been released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_queue fails when bytesize of
suite_nameis 5.Because marshal data includes "\n".