Run with spec directory by default for rspec-queue command#109
Merged
koic merged 1 commit intotmm1:masterfrom Apr 5, 2023
Merged
Conversation
koic
force-pushed
the
run_with_spec_dir_by_default_for_rspec_queue
branch
3 times, most recently
from
d343c5f to
95dc16a
Compare
…sing RSpec 3 ## Before Requrie a target target directory: ```console $ bundle exec test-queue spec ``` If the `spec` path is omitted, user might be surprised to see 0 test runs. ## After `spec` directory is target by default when target directory is ommited: ```console $ bundle exec test-queue ``` So, user can use it in the same abbreviated way as RSpec. ```console $ bundle exec rspec # spec directory by default target. ``` Note, however, that this PR implementation (i.e. `@files_or_directories_to_run`) is naive as it relies on: https://github.com/rspec/rspec-core/blob/v3.12.1/lib/rspec/core/configuration.rb#L1061-L1077 Note, it does not support legacy RSpec 2. So rspec.bats is copied to rspec2.bats and rspec3.bats, and adding new test case only to rspec3.bats.
koic
force-pushed
the
run_with_spec_dir_by_default_for_rspec_queue
branch
from
95dc16a to
d42d97e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Requrie a target target directory:
$ bundle exec test-queue specIf the
specpath is omitted, user might be surprised to see 0 test runs.After
specdirectory is target by default when target directory is ommited:$ bundle exec test-queueSo, user can use it in the same abbreviated way as RSpec.
$ bundle exec rspec # spec directory by default target.Note, however, that this PR implementation (i.e.
@files_or_directories_to_run) is naive as it relies on: https://github.com/rspec/rspec-core/blob/v3.12.1/lib/rspec/core/configuration.rb#L1061-L1077