Use monotonic clock for timestamp deltas when available #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djudd
commented
Jul 6, 2021
| int delta_to_first_unrecorded_gc_sample = 0; | ||
| int i; | ||
| int64_t delta_to_first_unrecorded_gc_sample = 0; | ||
| size_t i; |
There was a problem hiding this comment.
This is an incidental change but made a compiler warning go away.
|
Since I'm not sure @tmm1 is actively maintaining this anymore, @tenderlove want to take a look? |
|
It seems fine but I'll check more seriously (not from my phone lol) tomorrow. Thanks for sending this!! It makes sense to use the monotonic clock |
|
@tenderlove did you get a chance to check more seriously? |
|
@djudd sorry, I totally forgot. Just reviewed now, and it looks great! |
This was referenced Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for _POSIX_MONOTONIC_CLOCK and, if present, use
clock_gettimewithCLOCK_MONOTONICinstead of usinggettimeofday.I've verified that tests pass and use the monotonic clock on both Ubuntu 20.04.2 and macOS 11.4 (which apparently grew support for
clock_gettimerecently). Haven't tested on any other systems but did verify the tests still pass and don't use the monotonic clock if I munge the check.I don't write much C, so please tell me what terrible things I've done and how to make them better.