Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: secure now defaults to true (fixes #394) #405

Merged
merged 2 commits into from
Jul 16, 2020
Merged

client: secure now defaults to true (fixes #394) #405

merged 2 commits into from
Jul 16, 2020

Conversation

FoseFx
Copy link
Contributor

@FoseFx FoseFx commented Jul 15, 2020

@Meerkov proposed this change in #395 but that PR went stale
I changed the commit message as requested

Closes #395
Fixes #394

Copy link
Member

@AlcaDesign AlcaDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to set secure to true by default only if the server and port options are also default values. This would need to be checked within client.prototype.connect.

@FoseFx
Copy link
Contributor Author

FoseFx commented Jul 16, 2020

@AlcaDesign change made

@AlcaDesign AlcaDesign merged commit df228dc into tmijs:master Jul 16, 2020
@Meerkov
Copy link

Meerkov commented Jul 16, 2020

Doesn't that mean that if you set the port to 443, it would default to insecure again?

Users should have to go out of their way to turn off security.

@FoseFx
Copy link
Contributor Author

FoseFx commented Jul 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security defaults to OFF
3 participants