Fix helm.sh when workspace is set #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlegrone
approved these changes
Aug 25, 2019
Contributor
jlegrone
left a comment
jlegrone
left a comment
There was a problem hiding this comment.
I was running into the same issue with a named workspace and can confirm that this patch works. Thanks!
|
FWIW I gave up on my similar patch (#11) and we implemented a different suite of helm rules: https://github.com/dataform-co/dataform/tree/master/tools/helm - any future readers of this PR, feel free to use them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to have
workspace(name = "something")set in his/her repo. I had made a change for this in my previous PR about/bin/bashbut it was fixingbuildand breakingrun. This one should work.