This repository was archived by the owner on Jun 2, 2024. It is now read-only.
Bug-fix bingads random report-id name extension #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelDeanA
changed the title
|
Thank you, will merge this into an update this week! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently some reportIds from BingAds have had a name extension added to them. Instead of just eg, 620468266971 the reportId has been 620468266971_1649084551519 which causes issues when trying to open the file.
This bug-fix will remove everything that should not be in the reportId.
620468266971_1649084551519 -> 620468266971
This could probably be done in a nicer way, but I had to rush it as it is affecting our day-day business.