Skip to content
This repository was archived by the owner on Jun 2, 2024. It is now read-only.

Url encode spaces #20

Merged
merged 1 commit into from
May 3, 2021
Merged

Url encode spaces #20

merged 1 commit into from
May 3, 2021

Conversation

modernben
Copy link
Contributor

@modernben modernben commented May 3, 2021

When the scope is https://ads.microsoft.com/ads.manage offline_access some IDE's don't allow for clicking the whole url.

When the scope is 'https://ads.microsoft.com/ads.manage offline_access' some IDE's don't allow for clicking the whole url.
@timothymarois
Copy link
Member

Nice catch!

I wonder if it would also work to use rawurlencode to get any other characters?

@modernben
Copy link
Contributor Author

You could but then it would convert all characters to their entity equivalent.

So https:// would turn to https%3A%2F%2F. Not super friendly to look at.

@timothymarois
Copy link
Member

True. I'll get this into the next release!

Feel free to join our Discord channel

@timothymarois timothymarois merged commit 331bdb9 into tmarois:master May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants