Skip to content

Feature: custom queries - #32

Merged
tmahmood merged 2 commits into
tmahmood:mainfrom
monofox:feature/custom_queries
May 9, 2025
Merged

Feature: custom queries#32
tmahmood merged 2 commits into
tmahmood:mainfrom
monofox:feature/custom_queries

Conversation

@monofox

@monofox monofox commented May 5, 2025

Copy link
Copy Markdown
Contributor

This commit enables function to define custom queries within configuration file or by environment variables.

Its not scope of this commit to define custom queries on-the-fly on the ui.

Closes #24

This commit enables function to define custom queries
within configuration file or by environment variables.

Its not scope of this commit to define custom queries on-the-fly
on the ui.

Closes tmahmood#24
@monofox
monofox marked this pull request as ready for review May 7, 2025 13:54
@monofox
monofox marked this pull request as draft May 8, 2025 04:49
@monofox

monofox commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

I had to put it back to draft.
During testing in my own dev-test i stumbled across issues with the docker i did not faced locally.

For example:

web-1     |    0: __rustc::rust_begin_unwind
web-1     |    1: core::panicking::panic_fmt
web-1     |    2: core::result::unwrap_failed
web-1     |    3: <taskwarrior_web::core::app::AppState as core::default::Default>::default
web-1     |    4: taskwarrior_web::main::{{closure}}
web-1     |    5: tokio::runtime::park::CachedParkThread::block_on
web-1     |    6: tokio::runtime::context::runtime::enter_runtime
web-1     |    7: tokio::runtime::runtime::Runtime::block_on
web-1     |    8: taskwarrior_web::main
web-1     | note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
web-1     |
web-1     | thread 'main' panicked at src/core/app.rs:78:51:
web-1     | Config folder cannot be created.: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }
web-1     | stack backtrace:
web-1     |    0: __rustc::rust_begin_unwind
web-1     |    1: core::panicking::panic_fmt
web-1     |    2: core::result::unwrap_failed
web-1     |    3: <taskwarrior_web::core::app::AppState as core::default::Default>::default
web-1     |    4: taskwarrior_web::main::{{closure}}
web-1     |    5: tokio::runtime::park::CachedParkThread::block_on
web-1     |    6: tokio::runtime::context::runtime::enter_runtime
web-1     |    7: tokio::runtime::runtime::Runtime::block_on
web-1     |    8: taskwarrior_web::main
web-1     | note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Other errors included issues with permission when creating the .config folder (i did not had it mounted).

This commit enhances previous one to:
 - not fail if configuration file does not contain custom_queries part
 - ensure, that .config folder can be created in docker container as well
 - ensure, that a docker container can be stopped on SIGTERM
 - ensure, that right default logging setting is given.
@monofox
monofox marked this pull request as ready for review May 8, 2025 19:02
@monofox

monofox commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

Sorry for the confusion, now I'm ready.

@tmahmood
tmahmood merged commit 7ac8fa5 into tmahmood:main May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FeatureRequest: Custom queries.

2 participants