Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to bump support to Flutter Map v6 #89

Closed
wants to merge 2 commits into from
Closed

Conversation

bramp
Copy link
Contributor

@bramp bramp commented Oct 9, 2023

Changes required for Flutter Map v6, including migrating away from deprecated properties.

Fixes #87

@bramp bramp changed the title Changes to bump to support Flutter Maps v6 Changes to bump support to Flutter Map v6 Oct 9, 2023
@tlserver tlserver deleted the branch tlserver:v8 October 10, 2023 09:35
@tlserver tlserver closed this Oct 10, 2023
@tlserver
Copy link
Owner

tlserver commented Oct 10, 2023

Thanks you for contributing. I found some problems in this PR.

  1. Custom layers need to define their behaviour
    The way custom layers are defined has changed. Mobile/moving layers should now use MobileLayerTransformer at the top of their widget tree.

For this change, NonRotationContainer is not needed and can be removed.

  1. nonRotatedChildren has been removed
    The approach to 'mobile' and 'static' layers has been changed. Mobile layers now wrap themselves in a MobileLayerTransformer which uses the inherited state, instead of FlutterMap applying the affects directly to them. Static layers should now ensure they use Align and/or SizedBox.expand.

For this change, in the 4 examples used nonRotatedChildren, the widgets in nonRotatedChildren should be wraped in Align, otherwise Position widget throw an error.

Fixed these problems in 5f49fc53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants