Skip to content

test: Improve test coverage for logging package to 92% #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: Improve test coverage for logging package to 92% #235

wants to merge 2 commits into from

Conversation

ic0ns
Copy link
Contributor

@ic0ns ic0ns commented Jun 19, 2025

Summary

  • Added comprehensive tests for PatternSelectorSerializer class
  • Improved overall logging package coverage from 82% to 92% instruction coverage
  • Branch coverage improved from 62% to 75%

Key additions

  • LocationAwarePatternSelector test implementation
  • Tests for regex replacement functionality
  • Tests for location awareness in pattern selectors
  • Tests for serializer builder edge cases
  • Tests for builder constants validation

ic0ns added 2 commits June 19, 2025 06:34
@ic0ns
test: Add comprehensive tests for PatternSelectorSerializer
b9c7341 
- Add LocationAwarePatternSelector test implementation
- Test PatternSelectorSerializer with regex replacement
- Test PatternSelectorSerializer toString() method
- Test LocationAware pattern selector with requiresLocation
- Test PatternSelectorSerializer without regex replacement
- Test SerializerBuilder with pattern selector only
- Test builder constants validation
- Test invalid pattern handling in SerializerBuilder
- Test PatternSelectorSerializer toSerializable method directly

These tests improve coverage of the PatternSelectorSerializer class
from 11% to 100% instruction coverage.
@ic0ns
Merge branch 'main' into test/logging-coverage
e2a7413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ic0ns