[native] Fix location of TREAT_WARNINGS_AS_ERRORS

tlm365 · Jun 10, 2024 · 0504500 · 0504500
1 parent e7dc3a5
commit 0504500
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/presto-native-execution/CMakeLists.txt b/presto-native-execution/CMakeLists.txt
@@ -28,9 +28,6 @@ set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED True)
 message("Appending CMAKE_CXX_FLAGS with ${SCRIPT_CXX_FLAGS}")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${SCRIPT_CXX_FLAGS}")
-if("${TREAT_WARNINGS_AS_ERRORS}")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")
-endif()
 
 # Known warnings that are benign can be disabled.
 set(DISABLED_WARNINGS
@@ -209,4 +206,10 @@ else()
 endif()
 set(CMAKE_JOB_POOL_LINK presto_link_job_pool)
 
+# Adding this down here prevents warnings in dependencies from stopping the
+# build
+if("${TREAT_WARNINGS_AS_ERRORS}")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")
+endif()
+
 add_subdirectory(presto_cpp)