This repository was archived by the owner on Jun 28, 2021. It is now read-only.
Upgrade for React 16 #508
Open
Upgrade for React 16 #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Dropping support for React 0.14 and React 15
Full support for React 16 without warnings
This reverts commit 4e56f77.
…mponentWillUnmount
|
Hey @dmchurch, I'm not really using react-mdl anymore. If you're still using it, would you like to take over the project? I can add you as a contributor |
|
Yes, please do! maybe it could get moved to the react-mdl/react-mdl url
rather than tleunen/react-mdl?
…On Tue, Jan 28, 2020, 09:23 Tommy ***@***.***> wrote:
Hey @dmchurch <https://github.com/dmchurch>, I'm not really using
react-mdl anymore. If you're still using it, would you like to take over
the project? I can add you as a contributor
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#508?email_source=notifications&email_token=AAET46KTYZLWQTCAHIJ3YVLRAA5V3A5CNFSM4KDKX6BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDPDOI#issuecomment-579269049>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAET46LBATZMKUYTVYMEB5DRAA5V3ANCNFSM4KDKX6BA>
.
|
|
Actually, you already have all access (both github and npm) ;) |
|
That's weird, I couldn't push to master on my own! maybe you need to
transfer repo ownership to me? or invite me to the react-mdl project (in
addition to the repo)?
…On Tue, Jan 28, 2020, 09:45 Tommy ***@***.***> wrote:
Actually, you already have all access (both github and npm) ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#508?email_source=notifications&email_token=AAET46JXNVPCFWIDJWI43S3RABAJ7A5CNFSM4KDKX6BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDRVHA#issuecomment-579279516>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAET46NFTB5KWG3O5JVFCHTRABAJ7ANCNFSM4KDKX6BA>
.
|
|
Yeah, there was a check that required at least one reviewer. I removed it |
|
cool, thanks!
…On Tue, Jan 28, 2020, 09:57 Tommy ***@***.***> wrote:
Yeah, there was a check that required at least one reviewer. I removed it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#508?email_source=notifications&email_token=AAET46NMZHFAVVTXB4Z4ZDDRABBVVA5CNFSM4KDKX6BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDTBJY#issuecomment-579285159>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAET46NORDTRWPNUKQ6OUG3RABBVVANCNFSM4KDKX6BA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.