Skip to content

dolt: add page #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2021
Merged

dolt: add page #5475

merged 1 commit into from
Mar 19, 2021

Conversation

@bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Mar 19, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5471

@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Mar 19, 2021
@bl-ue bl-ue mentioned this pull request Mar 19, 2021
Open
33 tasks
@tansiret tansiret self-requested a review March 19, 2021 05:07
tansiret
tansiret approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@tansiret tansiret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@marchersimon
Copy link
Contributor

marchersimon commented Mar 19, 2021

I assume codespell shouldn't be in here?

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 19, 2021 •
edited
Loading

Haha, you're right, I based the add-dolt branch off of the add-codespell branch :) I'll clean that up, then you can merge 👍🏻

@bl-ue bl-ue requested a review from marchersimon March 19, 2021 12:31
@marchersimon marchersimon merged commit 025044f into tldr-pages:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tansiret tansiret tansiret approved these changes

+1 more reviewer

@marchersimon marchersimon marchersimon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bl-ue @marchersimon @tansiret