CLIENT-SPECIFICATION: add lowercasing of commands #5327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl-ue
added
clients
|
Won't we have to send out notifications to all of the clients about this change @sbrl? |
MasterOdin
changed the title
bl-ue
reviewed
Mar 1, 2021
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
|
The with this addition, the section becomes a bit unstructured. https://github.com/tldr-pages/tldr/blob/MasterOdin-patch-1/CLIENT-SPECIFICATION.md#page-names Is there any way to fix it? |
owenvoke
requested changes
Mar 9, 2021
owenvoke
approved these changes
Mar 9, 2021
bl-ue
reviewed
Mar 9, 2021
bl-ue
reviewed
Mar 11, 2021
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
bl-ue
approved these changes
Mar 11, 2021
|
Merging this as we have 3 approvals already. If there is any other concern in regards to this change, please reopen the discussion. |
|
This probably could have done with a version bump to v1.5 before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of landing tldr-lint@0.0.10 and resolving #5085 and #5255, I figured it would be good to add to the client specification about the lowercasing of file names as a transparent step to end users.