-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
subfinder: add page #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subfinder: add page #2178
Conversation
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amadeous, thanks for the new page.
Just a couple of comments. 👍
pages/common/subfinder.md
Outdated
> SubFinder is a subdomain discovery tool that discovers valid subdomains for websites. | ||
> Designed as a passive framework to be useful for bug bounties and safe for penetration testing. | ||
|
||
- Find subdomains for example.com: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps change to for a specific domain
. It's implied that example.com
is the example.
pages/common/subfinder.md
Outdated
|
||
`subfinder --silent -d {{example.com}}` | ||
|
||
- Use bruteforcing to find subdomainsxample description: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this was meant to be Use bruteforcing to find subdomains:
?
pages/common/subfinder.md
Outdated
@@ -0,0 +1,24 @@ | |||
# subfinder | |||
|
|||
> SubFinder is a subdomain discovery tool that discovers valid subdomains for websites. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As subfinder
is in the heading, perhaps change this to:
A subdomain discovery tool that discovers valid subdomains for websites.
pages/common/subfinder.md
Outdated
|
||
`subfinder -nW -d {{example.com}}` | ||
|
||
- Comma-separated list of resolvers to use: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a given comma-separated list of resolvers,
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being edited.The page follows the contributing guidelines.