Skip to content

subfinder: add page #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2018
Merged

subfinder: add page #2178

merged 3 commits into from
Jul 15, 2018

Conversation

amadeous
Copy link
Contributor

@amadeous amadeous commented Jul 10, 2018

  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2018

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/common/subfinder.md:6: TLDR005 Example descriptions should end in a colon
pages/common/subfinder.md:10: TLDR005 Example descriptions should end in a colon
pages/common/subfinder.md:18: TLDR005 Example descriptions should end in a colon
pages/common/subfinder.md:22: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amadeous, thanks for the new page.

Just a couple of comments. 👍

> SubFinder is a subdomain discovery tool that discovers valid subdomains for websites.
> Designed as a passive framework to be useful for bug bounties and safe for penetration testing.

- Find subdomains for example.com:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change to for a specific domain. It's implied that example.com is the example.


`subfinder --silent -d {{example.com}}`

- Use bruteforcing to find subdomainsxample description:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this was meant to be Use bruteforcing to find subdomains:?

@@ -0,0 +1,24 @@
# subfinder

> SubFinder is a subdomain discovery tool that discovers valid subdomains for websites.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As subfinder is in the heading, perhaps change this to:

A subdomain discovery tool that discovers valid subdomains for websites.


`subfinder -nW -d {{example.com}}`

- Comma-separated list of resolvers to use:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a given comma-separated list of resolvers,

@agnivade agnivade added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jul 11, 2018
@owenvoke owenvoke merged commit 6c199ca into tldr-pages:master Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants