Skip to content

CLIENT-SPECIFICATION: 2.3 release #15866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 7, 2025
Merged

CLIENT-SPECIFICATION: 2.3 release #15866

merged 7 commits into from
Mar 7, 2025

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Mar 5, 2025 •
edited
Loading

The client specifications are now in a good shape and ready for release.

Notable changes in this release:

  • Added longform/shortform specifications (#15253)
  • Specify common as a supported platform option (#15855)
  • Add the date of removal of the old asset website (#15862)
  • Various grammar fixes

@github-actions github-actions bot added the documentation Issues/PRs modifying the documentation. label Mar 5, 2025
@kbdharun
Copy link
Member

kbdharun commented Mar 5, 2025

#15862 and #15865 should be merged before this PR so marking it as draft (and the addition of date should probably be documented in the client spec files changelog too).

@kbdharun kbdharun marked this pull request as draft March 5, 2025 08:52
@Managor Managor mentioned this pull request Mar 5, 2025
Merged
@Managor Managor marked this pull request as ready for review March 5, 2025 18:46
@Managor
Copy link
Collaborator Author

Managor commented Mar 5, 2025 •
edited by acuteenvy
Loading

Since this view doesn't exist on Github, here's a screenshot of all the things that have changed since last tag

Screenshot

image

@Managor
Copy link
Collaborator Author

Managor commented Mar 5, 2025

Pinging everyone involved since the last change to the specs
@sbrl @acuteenvy @kbdharun @sebastiaanspeck @gutjuri @spageektti @niklasmohrin @MachiavelliII @nelsonfigueroa @cyqsimon

@Managor
Copy link
Collaborator Author

Managor commented Mar 5, 2025

Planned merge on Friday.

@Managor
Copy link
Collaborator Author

Managor commented Mar 6, 2025

Last minute terminology fix.

sebastiaanspeck
sebastiaanspeck approved these changes Mar 7, 2025
View reviewed changes
@Managor @sebastiaanspeck
Update CLIENT-SPECIFICATION.md
b8ffe9a 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
MachiavelliII
MachiavelliII approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@MachiavelliII MachiavelliII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Managor
Copy link
Collaborator Author

Managor commented Mar 7, 2025

And it's done. 🎉

@Managor Managor merged commit 3b17800 into tldr-pages:main Mar 7, 2025
4 checks passed
@Managor Managor deleted the release branch March 7, 2025 06:37
kbdharun
kbdharun reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda late with my review, but the overall changes LGTM.

sebastiaanspeck added a commit to sebastiaanspeck/tldr that referenced this pull request Mar 30, 2025
@Managor @sebastiaanspeck
CLIENT-SPECIFICATION: 2.3 release (tldr-pages#15866)
2e1e45b 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun left review comments

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@MachiavelliII MachiavelliII MachiavelliII approved these changes

@sbrl sbrl Awaiting requested review from sbrl sbrl is a code owner

Assignees
No one assigned
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Managor @kbdharun @sebastiaanspeck @MachiavelliII