Skip to content

secretsdump.py, impacket-secretsdump : add page #15812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MachiavelliII
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Feb 26, 2025
@MachiavelliII MachiavelliII changed the title Pages/common/secretsdump.py.md secretsdump.py: add page Feb 26, 2025
@MachiavelliII MachiavelliII mentioned this pull request Feb 26, 2025
62 tasks
@Managor Managor changed the title secretsdump.py: add page secretsdump.py,impacket-secretsdump : add page Feb 26, 2025
@Managor Managor changed the title secretsdump.py,impacket-secretsdump : add page secretsdump.py, impacket-secretsdump : add page Feb 26, 2025
Update examples
@Managor
Copy link
Collaborator

Managor commented Feb 27, 2025

Which users do you think make up a bigger portion: Those who install secretsdump.py or those who install impacket-secretsdump?

@MachiavelliII
Copy link
Member Author

There's a large portion of penetration testers and red teamers who use Kali, so they will have it by default as impacket-{{scriptname}}. However, regular users who installed it via pipx will have it under the name scriptname.py. We've already discussed this before, and I believe it's best to keep it this way.

Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@sebastiaanspeck sebastiaanspeck merged commit 6b3df4e into tldr-pages:main Mar 1, 2025
4 checks passed
@MachiavelliII MachiavelliII deleted the pages/common/secretsdump.py.md branch March 2, 2025 20:53
sebastiaanspeck added a commit to sebastiaanspeck/tldr that referenced this pull request Mar 30, 2025
* secretsdump.py: add page

* impacket-secretsdump: add Alias

* Update secretsdump.py.md

Update examples

* Update pages/common/secretsdump.py.md

Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>

---------

Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants