-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ghcid: add page #14611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghcid: add page #14611
Conversation
@sebastiaanspeck @vitorhcl Please review this PR |
@sebastiaanspeck I pulled upstream changed into my branch, please check PR now. |
Hey @sohang3112, thank you for inviting me to review your PR. If I have time, I will check it. There are enough other reviewers that can review this PR. |
Hey @sohang3112! Thanks for your enthusiasm in getting your PR reviewed. Just a friendly reminder: it’s usually best to avoid pinging specific reviewers unless a PR is urgent or has been waiting for feedback for a while. There are plenty of maintainers beyond the ones you tagged, and someone will definitely get to your PR when they have time. Since everyone here volunteers from different time zones and has their own schedules, reviews might take a bit of time. Thanks for understanding, and we really appreciate your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the suggestions
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc>
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc>
@gutjuri Committed your suggestions - please check now |
@spageektti Ok I'll keep it in mind from next time. Please review PR after changes when you're free |
common
,linux
,osx
,windows
,sunos
,android
, etc.