Skip to content

Conversation

sohang3112
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 0.8.9

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Nov 3, 2024
@sohang3112
Copy link
Contributor Author

@sebastiaanspeck @vitorhcl Please review this PR

@sohang3112
Copy link
Contributor Author

@sebastiaanspeck I pulled upstream changed into my branch, please check PR now.

@sebastiaanspeck
Copy link
Member

@sebastiaanspeck I pulled upstream changed into my branch, please check PR now.

Hey @sohang3112, thank you for inviting me to review your PR. If I have time, I will check it. There are enough other reviewers that can review this PR.

@spageektti
Copy link
Member

@sebastiaanspeck I pulled upstream changed into my branch, please check PR now.

Hey @sohang3112! Thanks for your enthusiasm in getting your PR reviewed. Just a friendly reminder: it’s usually best to avoid pinging specific reviewers unless a PR is urgent or has been waiting for feedback for a while. There are plenty of maintainers beyond the ones you tagged, and someone will definitely get to your PR when they have time. Since everyone here volunteers from different time zones and has their own schedules, reviews might take a bit of time. Thanks for understanding, and we really appreciate your contributions!

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the suggestions

sohang3112 and others added 2 commits November 5, 2024 09:54
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc>
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc>
@sohang3112
Copy link
Contributor Author

sohang3112 commented Nov 5, 2024

@gutjuri Committed your suggestions - please check now

@sohang3112
Copy link
Contributor Author

@spageektti Ok I'll keep it in mind from next time. Please review PR after changes when you're free

@spageektti spageektti merged commit b2a69f4 into tldr-pages:main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants