Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pi1toppm, ppmtopi1: add pages #12526

Merged
merged 2 commits into from
Mar 21, 2024
Merged

pi1toppm, ppmtopi1: add pages #12526

merged 2 commits into from
Mar 21, 2024

Conversation

gutjuri
Copy link
Member

@gutjuri gutjuri commented Mar 19, 2024

  • The page(s) are in the correct platform directories: `common`, `linux`, `osx`, `windows`, `sunos`, `android`, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Mar 19, 2024
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have some minor suggestions

pages/common/pi1toppm.md Outdated Show resolved Hide resolved
pages/common/ppmtopi1.md Outdated Show resolved Hide resolved
pages/common/pi1toppm.md Outdated Show resolved Hide resolved
pages/common/ppmtopi1.md Outdated Show resolved Hide resolved
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@gutjuri gutjuri merged commit 2957d86 into tldr-pages:main Mar 21, 2024
4 checks passed
@gutjuri gutjuri deleted the add-pi1toppm branch March 21, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants