Skip to content

md5sum: fix typo #10124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2023
Merged

md5sum: fix typo #10124

merged 2 commits into from
May 1, 2023

Conversation

acuteenvy
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

I updated the stdin example to be like in the b2sum page.
This also affects translations (Tamil and Italian), but I don't know the languages, so someone else has to fix those.
There's also Chinese, but it hasn't been updated in a while and this example doesn't exist there.

Closes #9910.

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Apr 28, 2023
@kbdharun kbdharun changed the title md5sum: fix typo and #9910 md5sum: fix typo Apr 29, 2023
@pixelcmtd pixelcmtd added the review needed Prioritized PRs marked for reviews from maintainers. label May 1, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution. I have a minor suggestion for this page.

@@ -9,11 +9,11 @@

- Calculate MD5 checksums for multiple files:

`md5sum {{path/to/file1}} {{path/to/filen2}}`
`md5sum {{path/to/file1}} {{path/to/file2}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`md5sum {{path/to/file1}} {{path/to/file2}}`
`md5sum {{path/to/file1 path/to/file2 ...}}`

I think this would apply here, as the description says it can calculate MD5 checksums for multiple files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once, this is addressed I will update the Tamil translation here or in a new PR (once merged).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get a small typo fix through and deal with that in a separate PR ^^

@pixelcmtd pixelcmtd added minor change Change(s) to an existing page(s) which is minor. and removed review needed Prioritized PRs marked for reviews from maintainers. labels May 1, 2023
@pixelcmtd pixelcmtd merged commit 415ebf8 into tldr-pages:main May 1, 2023
@acuteenvy acuteenvy deleted the md5sum branch May 1, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor change Change(s) to an existing page(s) which is minor. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md5sum: echo example has newline
3 participants