[Update]: package-lock.json dependencies #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vladimyr - Can you take a look at the CI failure ? Node stable is failing due to some strange cause. The Node 7 failure looks legit. |
4 tasks
|
Node 7 thing is indeed legit and I just opened PR to address it. It was due to race condition in test itself which is semi-good thing because only test was problematic and actual behavior of client wasn't compromised. I hope that after this fix we won't see it again 🤞 Regarding node stable one, I just eyeballed logs on travis and it looks weird 😵 Do you want me to investigate it further? Update: I just did and it seems that others have same issue too: nodejs/node#20281 It has to be caused by some 3rd party dependency... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Description
Update package-lock.json dependency