Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to the repository #14

Merged
merged 2 commits into from
May 13, 2020
Merged

Update references to the repository #14

merged 2 commits into from
May 13, 2020

Conversation

owenvoke
Copy link
Member

This is part of #13, note that I think we need to add org authentication for Coveralls, etc. for the badges to work. 👍

@owenvoke owenvoke added the documentation Improvements or additions to documentation label May 13, 2020
@ivanhercaz
Copy link
Collaborator

Wow! You're really awesome @owenvoke, thank you for update the references ❤️ I am going to check the reason of the build failed.

@ivanhercaz
Copy link
Collaborator

All right, I understand the reason of the fail.

The command "mix coveralls.travis" exited with 1.

As I include Coveralls in Travis, it seems this command doesn't run successfully, probably due it is necessary to configure Coveralls again. I will take a look.

@ivanhercaz
Copy link
Collaborator

The build failed yet :/ That seems strange.

@owenvoke
Copy link
Member Author

owenvoke commented May 13, 2020

Yeah, I hadn't actually enabled it on this repository. sigh Coveralls should now work 🤦

Quick question, do we need to setup the repo_token for Travis? 🤔
Guess not, it's passed 🎉

@ivanhercaz
Copy link
Collaborator

Yeah, I hadn't actually enabled it on this repository. sigh Coveralls should now work

Okay! It has sense, now it works really fine. Alls builds are passing the tests.

Quick question, do we need to setup the repo_token for Travis?

If I am honest, @owenvoke, I didn't remember to setup any repo_token for Travis. I think it is just necessary when it is a private repository.

@ivanhercaz
Copy link
Collaborator

Nice! It is just necessary to setup Codacy and everything will be as before the transfer.

Copy link
Collaborator

@ivanhercaz ivanhercaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks... awesome to me! Thank you very much for change all the old references, @owenvoke. We have two options now:

  1. Wait for someone of the organization grants to Codacy the access to this repository to have the badges working.
  2. Merge this PR and then wait, although the link of the Codacy badge will returns an not found error.

@owenvoke
Copy link
Member Author

owenvoke commented May 13, 2020

I've also enabled Codacy now 👌 Looks like the badge needs to be updated though to:
[![Codacy Badge](https://api.codacy.com/project/badge/Grade/83d63c07f9ca45af9fac591a2c51e8e6)](https://www.codacy.com/gh/tldr-pages/extldr)

Codacy Badge
If anyone wants to update my PR to amend that, feel free. Or I'll do it first thing tomorrow. 👍

@ivanhercaz
Copy link
Collaborator

I've also enabled Codacy now Looks like the badge needs to be updated though to:
[![Codacy Badge](https://api.codacy.com/project/badge/Grade/83d63c07f9ca45af9fac591a2c51e8e6)](https://www.codacy.com/gh/tldr-pages/extldr)

Codacy Badge
If anyone wants to update my PR to amend that, feel free. Or I'll do it first thing tomorrow.

Awesome! I will update the PR and then merge it. Again, thank you very much, @owenvoke, for all your help with this issue.

@CLAassistant
Copy link

CLAassistant commented May 13, 2020

CLA assistant check
All committers have signed the CLA.

@ivanhercaz
Copy link
Collaborator

Nice! Now it is being running the

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

ivanhercaz
owenvoke
You have signed the CLA already but the status is still pending? Let us recheck it.

@owenvoke, I prefer to wait until you sign the CLA. No hurry for this, so this PR can be merged tomorrow (feel free to merge it by yourself). I will try to work in another issues tonight.

@owenvoke
Copy link
Member Author

Signed! So you're free to merge. 👌 I should probably get some sleep though.

@ivanhercaz
Copy link
Collaborator

Signed! So you're free to merge.

Thank you very much! I am going to merge it 🎉

I should probably get some sleep though.

I hope you rest and have sweet dreams!

@ivanhercaz ivanhercaz merged commit 2cfd0b6 into tldr-pages:master May 13, 2020
@owenvoke owenvoke deleted the feature/references branch May 14, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change all the references to old repository to the new location in tldr-pages organization
3 participants