Set HIDE_PRIVATE_SYMBOLS ON for manylinux/osx/conda packages. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leandron we might also need that for conda packages and mac https://github.com/tlc-pack/tlcpack/blob/main/conda/recipe/build.sh |
* This is to workaround an issue caused by conflicting LLVM versions, first observed by since we updated Pytorch in TVM * Discussion at: apache/tvm#9362
leandron
force-pushed
the
hide-private-symbols
branch
from
3013b13
to
fb55487
Compare
leandron
changed the title
I updated the PR to reflect that. |
tqchen
approved these changes
Nov 2, 2021
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Nov 4, 2021
This test was originally disabled due to the issue documented in apache#7455 affecting CI. I believe this has since been resolved by apache#9362. Note: This patch should not be merged until the changes in https: //github.com/tlc-pack/tlcpack/pull/81 are reflected in CI. Change-Id: Ib918595a1d9149e3c858ca761861304450cbfe13
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Nov 5, 2021
This test was originally disabled due to the issue documented in apache#7455 affecting CI. I believe this has since been resolved by apache#9362. Note: This patch should not be merged until the changes in https: //github.com/tlc-pack/tlcpack/pull/81 are reflected in CI. Change-Id: Ib918595a1d9149e3c858ca761861304450cbfe13
masahi
pushed a commit
to apache/tvm
that referenced
this pull request
Nov 6, 2021
This test was originally disabled due to the issue documented in #7455 affecting CI. I believe this has since been resolved by #9362. Note: This patch should not be merged until the changes in https: //github.com/tlc-pack/tlcpack/pull/81 are reflected in CI. Change-Id: Ib918595a1d9149e3c858ca761861304450cbfe13
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
This test was originally disabled due to the issue documented in apache#7455 affecting CI. I believe this has since been resolved by apache#9362. Note: This patch should not be merged until the changes in https: //github.com/tlc-pack/tlcpack/pull/81 are reflected in CI. Change-Id: Ib918595a1d9149e3c858ca761861304450cbfe13
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
This test was originally disabled due to the issue documented in apache#7455 affecting CI. I believe this has since been resolved by apache#9362. Note: This patch should not be merged until the changes in https: //github.com/tlc-pack/tlcpack/pull/81 are reflected in CI. Change-Id: Ib918595a1d9149e3c858ca761861304450cbfe13
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
This test was originally disabled due to the issue documented in apache#7455 affecting CI. I believe this has since been resolved by apache#9362. Note: This patch should not be merged until the changes in https: //github.com/tlc-pack/tlcpack/pull/81 are reflected in CI. Change-Id: Ib918595a1d9149e3c858ca761861304450cbfe13
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This test was originally disabled due to the issue documented in apache#7455 affecting CI. I believe this has since been resolved by apache#9362. Note: This patch should not be merged until the changes in https: //github.com/tlc-pack/tlcpack/pull/81 are reflected in CI. Change-Id: Ib918595a1d9149e3c858ca761861304450cbfe13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to workaround an issue caused by conflicting LLVM
versions, first observed by since we updated Pytorch in TVM
Discussion at: [Bug] PyTorch and TVM loading problem due to conflicting LLVM symbols apache/tvm#9362