Adapt to changes in the lsp server. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kape1395
commented
Jan 22, 2024
•
kape1395
commented
- Updated the proof step icons to use the material icons.
- Rewrote the proof step details panel to use react and improved the style.
- Adapted to the changes in the LSP server.
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
|
@lemmy, should I wait for a review or merge it right away? |
lemmy
reviewed
Jan 30, 2024
Makefile
Outdated
| @@ -0,0 +1,5 @@ | |||
| all: compile | |||
|
|
|||
| compile: | |||
There was a problem hiding this comment.
I'm no big fan of the typescript/javascript build, but this makefile is not complete. IMO, this is more confusing then helping.
There was a problem hiding this comment.
I added this as a reminder for myself, but you are right; that might be confusing for others. I will remove it, as I'm not sure how to make it more complete.
lemmy
reviewed
Jan 30, 2024
There was a problem hiding this comment.
I thought of keeping the file structure similar in all components. But I will remove it to decrease confusion :)
lemmy
approved these changes
Jan 30, 2024
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.