-
Notifications
You must be signed in to change notification settings - Fork 4
Drop libegl1-mesa (libegl1 suffices) #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop libegl1-mesa (libegl1 suffices) #66
Conversation
|
cc: @Czaki |
tlambert03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
|
I was loking where is diffewrence betwen here and PartSeg https://github.com/4DNucleome/PartSeg/blob/ca2021b86e836673ec8f1345aa26ed79d3d85153/.github/workflows/base_test_workflow.yml#L65 And I have libgel1 and it works, so it looks like good spot: https://github.com/4DNucleome/PartSeg/actions/runs/11298297824/job/31426973370?pr=1207 |
|
Not sure if it's runner caching or what, but that repo is still using jammy even though I've specified ubuntu-latest I've also had actions using latest work on other repos today, so I think not all latest runners are 24.04 |
|
ah shoot... sorry I missed this @psobolewskiPhD, in the future, you should edit index.js. the dist/index.js is autogenerated at build time (though it needs to be commited to work with github actions). will fix |
|
Derp sorry @tlambert03 I should have read more carefully |
Closes #65
As noted #65 (comment) it appears that libegl1-mesa was a transitional dummy package for libegl1, going back as far as 20.04
So dropping it and just using libegl1 should suffice. I tested my branch here:
psobolewskiPhD/i2k2024_napari_workshop@95fb709
and my action worked.
Not sure how else to test.
It's possible this works all the way back to ubuntu 18, but GitHub doesn't have those runners anymore, so it shouldn't matter?