Skip to content

Conversation

@psobolewskiPhD
Copy link
Contributor

@psobolewskiPhD psobolewskiPhD commented Oct 11, 2024

Closes #65

As noted #65 (comment) it appears that libegl1-mesa was a transitional dummy package for libegl1, going back as far as 20.04
So dropping it and just using libegl1 should suffice. I tested my branch here:
psobolewskiPhD/i2k2024_napari_workshop@95fb709
and my action worked.
Not sure how else to test.

It's possible this works all the way back to ubuntu 18, but GitHub doesn't have those runners anymore, so it shouldn't matter?

@psobolewskiPhD
Copy link
Contributor Author

cc: @Czaki

Copy link
Owner

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Czaki
Copy link
Contributor

Czaki commented Oct 11, 2024

@psobolewskiPhD
Copy link
Contributor Author

psobolewskiPhD commented Oct 11, 2024

Not sure if it's runner caching or what, but that repo is still using jammy even though I've specified ubuntu-latest
https://github.com/psobolewskiPhD/i2k2024_napari_workshop/actions/runs/11299712535/job/31431218742
Here's the workflow file with ubuntu-latest and my action branch:
https://github.com/psobolewskiPhD/i2k2024_napari_workshop/actions/runs/11299712535/workflow

I've also had actions using latest work on other repos today, so I think not all latest runners are 24.04

@psobolewskiPhD
Copy link
Contributor Author

psobolewskiPhD commented Oct 11, 2024

@tlambert03 tlambert03 merged commit 06a5339 into tlambert03:main Oct 11, 2024
@tlambert03
Copy link
Owner

ah shoot... sorry I missed this @psobolewskiPhD, in the future, you should edit index.js. the dist/index.js is autogenerated at build time (though it needs to be commited to work with github actions). will fix

tlambert03 added a commit that referenced this pull request Oct 11, 2024
@psobolewskiPhD
Copy link
Contributor Author

Derp sorry @tlambert03 I should have read more carefully
#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing libegl1-mesa

3 participants