Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sorting of generated code for consistency #29

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

jmuhlich
Copy link
Collaborator

@jmuhlich jmuhlich commented Aug 7, 2020

Switch from sets to lists in a few places to preserve insertion order.
Explicitly sort field_plurals.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

Merging #29 into master will decrease coverage by 0.28%.
The diff coverage is 97.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   95.20%   94.91%   -0.29%     
==========================================
  Files           1        1              
  Lines         396      433      +37     
==========================================
+ Hits          377      411      +34     
- Misses         19       22       +3     
Impacted Files Coverage Δ
src/ome_autogen.py 94.91% <97.52%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ea38b...92f8e2a. Read the comment docs.

Switch from sets to lists in a few places to preserve insertion order.
Explicitly sort field_plurals.
@jmuhlich jmuhlich merged commit 148954b into tlambert03:master Aug 7, 2020
@jmuhlich jmuhlich deleted the codegen-sort branch August 7, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants