Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix import of removed private vendored attr in pydantic #215

Merged
merged 4 commits into from
Aug 20, 2023

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Aug 18, 2023

pydantic broke their own pydantic-extra-types library (and we had vendored it)

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #215 (f3dea42) into main (5754342) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   86.48%   86.48%           
=======================================
  Files          26       26           
  Lines        1250     1250           
=======================================
  Hits         1081     1081           
  Misses        169      169           
Files Changed Coverage Δ
src/ome_types/_pydantic_compat.py 98.46% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 changed the title fix: fix import of removed private vendored attr in pydantiuc fix: fix import of removed private vendored attr in pydantic Aug 18, 2023
@tlambert03 tlambert03 enabled auto-merge (squash) August 18, 2023 01:20
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2023

CodSpeed Performance Report

Merging #215 will degrade performances by 61.08%

Comparing fix-color (f3dea42) with main (5754342)

Summary

❌ 1 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-color Change
test_time_from_xml[large] 6.7 s 17.3 s -61.08%

@CGDogan
Copy link

CGDogan commented Aug 20, 2023

Thanks this is what we users of this library need

@tlambert03
Copy link
Owner Author

Thanks for letting me know @CGDogan, will cut a new release today

@tlambert03 tlambert03 merged commit cdde6f7 into main Aug 20, 2023
@tlambert03 tlambert03 deleted the fix-color branch August 20, 2023 12:47
@tlambert03 tlambert03 added the bug Something isn't working label Aug 20, 2023
@CGDogan
Copy link

CGDogan commented Aug 20, 2023

thanks it's now working excellent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants