Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for legacy SDK #2

Merged
merged 23 commits into from
Sep 29, 2021
Merged

add support for legacy SDK #2

merged 23 commits into from
Sep 29, 2021

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Sep 26, 2021

edit
though this doesn't actually "integrate" the legacy SDK into the main ND2File object... I'm merging at this point because i want this in main so I can work on smaller bits of functionality in smaller PRs

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2021

Codecov Report

Merging #2 (3da703a) into main (4bbc1be) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main      #2    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          4       5     +1     
  Lines        303     498   +195     
======================================
- Misses       303     498   +195     
Impacted Files Coverage Δ
nd2/__init__.py 0.00% <0.00%> (ø)
nd2/_chunkmap.py 0.00% <0.00%> (ø)
nd2/_util.py 0.00% <0.00%> (ø)
nd2/nd2file.py 0.00% <0.00%> (ø)
nd2/structures.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bbc1be...3da703a. Read the comment docs.

@tlambert03 tlambert03 merged commit 091872c into main Sep 29, 2021
@tlambert03 tlambert03 deleted the legacy2 branch September 29, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants